Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception translations to System Bridge integration #112206

Merged

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Mar 4, 2024

Proposed change

Adds translations for exceptions on System Bridge integration.

Type of change

  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@timmo001
Copy link
Contributor Author

Merge conflicts resolved

@timmo001 timmo001 force-pushed the systembridge-error-translations branch from ffa3d6c to 7e1dc59 Compare March 27, 2024 17:26
@timmo001 timmo001 force-pushed the systembridge-error-translations branch from 7e1dc59 to 29f5004 Compare April 2, 2024 18:58
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @timmo001 👍

@emontnemery emontnemery merged commit 65e6e1f into home-assistant:dev May 15, 2024
17 checks passed
@timmo001 timmo001 deleted the systembridge-error-translations branch May 15, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants