Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sun entity description required fields mixin #105848

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Dec 16, 2023

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Swamp-Ig, mind taking a look at this pull request as it has been labeled with an integration (sun) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sun can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sun Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jpbede jpbede marked this pull request as draft December 16, 2023 08:56
@jpbede
Copy link
Member Author

jpbede commented Dec 16, 2023

Drafting to wait for #105512

@bdraco
Copy link
Member

bdraco commented Dec 16, 2023

Should be unblocked now

@jpbede
Copy link
Member Author

jpbede commented Dec 16, 2023

Oh, nice, thanks @bdraco 👍

@jpbede
Copy link
Member Author

jpbede commented Dec 16, 2023

Hm mypy is still not happy, still getting `Cannot inherit frozen dataclass from a non-frozen oneà. Although I've rebased

@jpbede jpbede force-pushed the sun-required-mixin branch from 9bfe146 to 40c5666 Compare December 16, 2023 09:46
@bdraco
Copy link
Member

bdraco commented Dec 16, 2023

I'm not sure whats going on there (and its way too late here to dig in), but it might be we need to adjust the typing

@dataclasses.dataclass(frozen=True)

cc @emontnemery

@emontnemery
Copy link
Contributor

emontnemery commented Dec 18, 2023

It's not possible to set the frozen flag until #105984 is merged

@bdraco
Copy link
Member

bdraco commented Dec 18, 2023

Thanks Erik

@jpbede jpbede force-pushed the sun-required-mixin branch from 40c5666 to 1e373b9 Compare December 19, 2023 09:07
@jpbede jpbede marked this pull request as ready for review December 19, 2023 09:07
@jpbede jpbede requested a review from allenporter as a code owner December 19, 2023 09:07
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated commits in this PR @jpbede?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 19, 2023 09:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jpbede
Copy link
Member Author

jpbede commented Dec 19, 2023

Oh dang, thanks

@jpbede jpbede force-pushed the sun-required-mixin branch from 1e373b9 to fc58bb0 Compare December 19, 2023 09:31
@jpbede jpbede removed the request for review from allenporter December 19, 2023 09:31
@jpbede jpbede marked this pull request as ready for review December 19, 2023 09:31
@home-assistant home-assistant bot requested a review from frenck December 19, 2023 09:31
@jpbede
Copy link
Member Author

jpbede commented Dec 19, 2023

@frenck fixed, thanks for spotting.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jpbede 👍

../Frenck

@jpbede jpbede merged commit bb6f78d into home-assistant:dev Dec 19, 2023
53 checks passed
@jpbede jpbede deleted the sun-required-mixin branch December 19, 2023 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants