-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sun entity description required fields mixin #105848
Conversation
Hey there @Swamp-Ig, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Drafting to wait for #105512 |
Should be unblocked now |
Oh, nice, thanks @bdraco 👍 |
Hm mypy is still not happy, still getting `Cannot inherit frozen dataclass from a non-frozen oneà. Although I've rebased |
9bfe146
to
40c5666
Compare
I'm not sure whats going on there (and its way too late here to dig in), but it might be we need to adjust the typing core/tests/helpers/test_entity.py Line 1681 in 104bcc6
cc @emontnemery |
It's not possible to set the frozen flag until #105984 is merged |
Thanks Erik |
40c5666
to
1e373b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are unrelated commits in this PR @jpbede?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Oh dang, thanks |
1e373b9
to
fc58bb0
Compare
@frenck fixed, thanks for spotting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jpbede 👍
../Frenck
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: