Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js-server-python to 0.55.1 #105502

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Bump zwave-js-server-python to 0.55.1 #105502

merged 2 commits into from
Dec 26, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Dec 11, 2023

Proposed change

Changelogs:

Main changes:

  • uses orjson when available
  • Adds additional information to the initial state dump for rebuilding routes so we can display route information more quickly
  • Adds some additional CC constants @TastyPi
  • Adds some missing value metadata properties, one of which is needed for certification
  • Revert breaking change that was not needed

home-assistant/addons#3351 must be merged first EDIT: This is no longer true even though it was merged already

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

MartinHjelmare
MartinHjelmare previously approved these changes Dec 11, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've talked about that we should not label these PRs as breaking, but maybe we should still do that until the repair issue description is more detailed about what version is required and what the user needs to do. I had a suggestion that we should link the user to the github release they need, depending on how they run the server.

@raman325
Copy link
Contributor Author

raman325 commented Dec 11, 2023

thanks for the reminder, I will create an issue in the lib repo so we don't forget to work on that. Outside of OS, can we know how they run the server? I don't think we collect that information. Might be worth an enhancement of some sort though

@raman325 raman325 marked this pull request as draft December 25, 2023 08:22
@raman325
Copy link
Contributor Author

I think we should go straight to 0.55.1 to avoid the breaking change so will mark this as draft until we have the patch version released

@raman325 raman325 changed the title Bump zwave-js-server-python to 0.55.0 Bump zwave-js-server-python to 0.55.1 Dec 26, 2023
@raman325 raman325 marked this pull request as ready for review December 26, 2023 03:49
@raman325
Copy link
Contributor Author

coverage failures are unrelated to this PR

@raman325 raman325 merged commit 18ace16 into dev Dec 26, 2023
52 of 53 checks passed
@raman325 raman325 deleted the zwave_bump branch December 26, 2023 04:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants