Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dsmr-parser to 1.3.1 to fix parsing issues #103572

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dupondje
Copy link
Contributor

@dupondje dupondje commented Nov 7, 2023

Breaking change

Proposed change

Update to newer version of dsmr-parser which fixes parsing errors when the peak usage data contains invalid data.

Changelog: https://github.com/ndokter/dsmr_parser/releases/tag/v1.3.1
https://github.com/ndokter/dsmr_parser/blob/master/CHANGELOG.rst
Diff between 1.3.0 and 1.3.1: ndokter/dsmr_parser@v1.3.0...v1.3.1

Fixes: #103233

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Update to newer version of dsmr-parser which fixes parsing errors when the peak usage
data contains invalid data.

Fixes: home-assistant#103233
@home-assistant
Copy link

home-assistant bot commented Nov 7, 2023

Hey there @RobBie1221, @frenck, mind taking a look at this pull request as it has been labeled with an integration (dsmr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dsmr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dsmr Removes the current integration label and assignees on the pull request, add the integration domain after the command.

janiversen
janiversen previously approved these changes Nov 7, 2023
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@joostlek
Copy link
Member

joostlek commented Nov 7, 2023

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@janiversen janiversen dismissed their stale review November 7, 2023 09:17

Overlooked missing link.

@dupondje
Copy link
Contributor Author

dupondje commented Nov 7, 2023

Fixed :)

Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@janiversen janiversen merged commit 3ca6cdd into home-assistant:dev Nov 7, 2023
50 checks passed
@joostlek joostlek added this to the 2023.11.2 milestone Nov 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSMR integration breaks on 2023.11.0 for 5B
4 participants