Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plugwise Schedule selection #103262

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

CoMPaTech
Copy link
Contributor

Proposed change

Intended bugfix for #103251 - supporting call arguments ordering was wrong

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2023

Hey there @bouwew, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@CoMPaTech CoMPaTech changed the title Bugfix for 103251 Fix Plugwise Schedule selection Nov 2, 2023
@CoMPaTech
Copy link
Contributor Author

Pending test/review by other code owners as well before lifting draft

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good fix!
Sorry for the mistake :(

@CoMPaTech CoMPaTech marked this pull request as ready for review November 2, 2023 18:05
@CoMPaTech CoMPaTech requested a review from frenck as a code owner November 2, 2023 18:05
@CoMPaTech
Copy link
Contributor Author

As on internal check - no worries, we both missed it.

@frenck frenck added this to the 2023.11.1 milestone Nov 3, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

../Frenck

@frenck frenck merged commit 2a31eb6 into home-assistant:dev Nov 3, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Nov 3, 2023
@frenck frenck mentioned this pull request Nov 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugwise invalid schedule state - unable to change schedule from HA
3 participants