Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reolink-aio to 0.7.14 and improve typing of Reolink #103129

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Oct 31, 2023

Breaking change

Proposed change

Improve typing of the Reolink integration because the next reolink-aio version is going to include a py.typed file to allow HomeAssistant to use the typings of reolink-aio during the mypy check.

Bump reolink-aio to 0.7.14:
Bug fixes:

Optimizations:

Full Changelog: starkillerOG/reolink_aio@0.7.12...0.7.14

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy is failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft October 31, 2023 15:23
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@starkillerOG starkillerOG marked this pull request as ready for review October 31, 2023 18:14
@home-assistant home-assistant bot requested a review from joostlek October 31, 2023 18:14
@starkillerOG starkillerOG requested a review from jbouwh November 2, 2023 08:46
@home-assistant home-assistant bot marked this pull request as draft November 2, 2023 10:27
@starkillerOG starkillerOG marked this pull request as ready for review November 2, 2023 11:24
@starkillerOG starkillerOG changed the title Improve typing of Reolink Bump reolink-aio to 0.7.13 and improve typing of Reolink Nov 3, 2023
@starkillerOG
Copy link
Contributor Author

I would have liked to seperate the version bump and typing improvements in two PRs, but unfortunetely that is not possible due to a chicken and egg problem:

A seperate version bump would fail because it includes the py.typed so mypy would fail due to some needed typing improvements in HA.
As seen from previous run a seperate typing improvement would fail due to the py.typed beeing needed to use Literal[Subtype.push] in HA, therefore needing the version bump.

@starkillerOG starkillerOG added this to the 2023.11.1 milestone Nov 3, 2023
@MartinHjelmare
Copy link
Member

This is expected.

@frenck frenck modified the milestones: 2023.11.1, 2023.11.2 Nov 3, 2023
@home-assistant home-assistant bot marked this pull request as draft November 3, 2023 11:58
@starkillerOG starkillerOG marked this pull request as ready for review November 3, 2023 15:24
@MartinHjelmare MartinHjelmare changed the title Bump reolink-aio to 0.7.13 and improve typing of Reolink Bump reolink-aio to 0.7.14 and improve typing of Reolink Nov 3, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 1df69f5 into home-assistant:dev Nov 3, 2023
56 checks passed
@starkillerOG starkillerOG deleted the reolink_typing branch November 3, 2023 16:06
@starkillerOG
Copy link
Contributor Author

Thanks for all the help and patience with this PR everyone!
It was a bit clumsy on my part.

@frenck frenck modified the milestones: 2023.11.2, 2023.11.1 Nov 4, 2023
frenck pushed a commit that referenced this pull request Nov 4, 2023
* Improve typing

* fix mypy

* Further improve typing

* Restore Literal typing

* Bump reolink_aio to 0.7.13

* Bump reolink-aio to 0.7.14
@frenck frenck mentioned this pull request Nov 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants