-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump reolink-aio to 0.7.14 and improve typing of Reolink #103129
Bump reolink-aio to 0.7.14 and improve typing of Reolink #103129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy is failing, can you take a look?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I would have liked to seperate the version bump and typing improvements in two PRs, but unfortunetely that is not possible due to a chicken and egg problem: A seperate version bump would fail because it includes the py.typed so mypy would fail due to some needed typing improvements in HA. |
This is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for all the help and patience with this PR everyone! |
* Improve typing * fix mypy * Further improve typing * Restore Literal typing * Bump reolink_aio to 0.7.13 * Bump reolink-aio to 0.7.14
Breaking change
Proposed change
Improve typing of the Reolink integration because the next reolink-aio version is going to include a
py.typed
file to allow HomeAssistant to use the typings of reolink-aio during the mypy check.Bump reolink-aio to 0.7.14:
Bug fixes:
Optimizations:
Full Changelog: starkillerOG/reolink_aio@0.7.12...0.7.14
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: