-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some entity categories to Reolink #102141
Conversation
Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Comments addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
A bit off topic, but would like some input: |
I don't know. I haven't checked the code very thorough. Generally it's the code owner opening a PR and marking things as checked. And they will be verifiedi n the PR. |
@starkillerOG Example: #102069 |
Should is_recording switch have a config entity category? |
Thanks for the info, will look into the quality scaled. @balloob yes I think is_recording can be considered config. I did not add it yet since I think it is one of the main features of the camera (to record), and I did not want to push it to the bottom of the device page together with other less relevant settings. But indeed it is a setting not a pysicall control. So we can add the category |
PR for record category #102439 |
Breaking change
Proposed change
Recently got a Reolink PoE camera. Noticed a couple of entities missing the entity category.
Maybe person/motion could be considered diagnostic too but that can be for a future discussion.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: