-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch hassio to use iter_chunks #102031
Switch hassio to use iter_chunks #102031
Conversation
This was ~7% faster downloading backups because it did not have to re-package the data as much
This was ~7% faster downloading backups because it did not have to re-package the data as much
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Looks great.
Reading through the streams code I can see what you're saying: iter chunked just pops http chunks directly, rather than trying to partial read / split the chunks. Just adding commentary to give visibility into the review.
Edit: Too slow :)
Thanks everyone |
Proposed change
This was ~7% faster downloading backups because it did not
have to re-package the data as much
https://docs.aiohttp.org/en/stable/streams.html#aiohttp.StreamReader.iter_chunks
This makes sense for a proxy like operation.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: