Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Add index to docker file #101048

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: Add index to docker file #101048

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 28, 2023

Proposed change

Add index to docker file

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Sep 28, 2023
ENV \
S6_SERVICES_GRACETIME=220000
S6_SERVICES_GRACETIME=220000 \
EXTRA_INDEX_URL=https://wheels.home-assistant.io/musllinux-index/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for testing only, remove this in favor of home-assistant/docker#297

@@ -17,7 +20,7 @@ RUN \
--no-cache-dir \
--no-index \
--only-binary=:all: \
--find-links "${WHEELS_LINKS}" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these we can probably use --index-url

@frenck
Copy link
Member

frenck commented Sep 30, 2023

Closing this one, we have deployed at this point. Will rework this part later when 2023.10 has been shipped.

../Frenck

@frenck frenck closed this Sep 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2023
@bdraco bdraco deleted the dock_index branch October 22, 2023 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants