Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration met (meteorologisk institutt) does not provide the correct information (at night) #89001

Closed
ChristophCaina opened this issue Mar 1, 2023 · 8 comments · Fixed by #103334
Assignees

Comments

@ChristophCaina
Copy link
Contributor

The problem

file /homeassistant/components/met/const.py is clearly showing the following information available:

from homeassistant.components.weather import (
    ATTR_CONDITION_CLEAR_NIGHT,

but within the card, only "Sunny" will be shown - even at midnight.

The Screenshot compares the information provided by AccuWeather (top) and the information provided by the 'met' integration at the same time (the time can be seen below in the tile card)
grafik

What version of Home Assistant Core has the issue?

2023.03.01

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

met

Link to integration documentation on our website

https://www.home-assistant.io/integrations/met

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Mar 1, 2023

Hey there @Danielhiversen, @thimic, mind taking a look at this issue as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of met can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign met Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


met documentation
met source
(message by IssueLinks)

@sevorl
Copy link

sevorl commented Mar 21, 2023

Would be great to get this fixed

@unclehack
Copy link

The met.no API returns cloudy and partlycloudy for the night forecast. This isn't handled in a correct way in the HA code. cloudy, partlycloudy and clear conditions can apply both to the day and to the night.

HA appears to be missing logic to decide if it should use an icon with the sun or something else based on the sunset and sunrise.

Some examples would be

  • if the sun sets before that time, show clear/cloudy/partlycloudy/etc night for all time intervals until the sun rises
  • if the sun rises before that time, show clear/cloudy/partlycloudy/etc with a sun icon until sunset

@unclehack
Copy link

@thimic @frenck: Maybe you have an idea who could look at this?

@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@unclehack
Copy link

The problem hasn't been fixed. The issue shouldn't be closed.

@github-actions github-actions bot removed the stale label Aug 3, 2023
@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@iPeel
Copy link

iPeel commented Nov 1, 2023

This issue needs to be kept open, it's still very much an issue as 3AM shows bright sunshine on the forecast.

@github-actions github-actions bot removed the stale label Nov 1, 2023
jrieger added a commit to jrieger/home-assistant-core that referenced this issue Nov 3, 2023
jpbede added a commit that referenced this issue Nov 4, 2023
* Report correct weather condition at night for Met, fixes #68369, fixes #89001

* Update homeassistant/components/met/weather.py

Co-authored-by: Jan-Philipp Benecke <[email protected]>

---------

Co-authored-by: Jan-Philipp Benecke <[email protected]>
frenck pushed a commit that referenced this issue Nov 4, 2023
* Report correct weather condition at night for Met, fixes #68369, fixes #89001

* Update homeassistant/components/met/weather.py

Co-authored-by: Jan-Philipp Benecke <[email protected]>

---------

Co-authored-by: Jan-Philipp Benecke <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants