Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about mobile data sensors #435

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Add notes about mobile data sensors #435

merged 2 commits into from
Jan 28, 2021

Conversation

frimtec
Copy link
Contributor

@frimtec frimtec commented Jan 24, 2021

Documentation for home-assistant/android#1317

@homeassistant
Copy link
Contributor

Hi @frimtec,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@TomBrien
Copy link
Member

Parent: home-assistant/android#1317

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to the Android API being used to match the rest of the Android sensors.

@@ -434,6 +435,14 @@ This sensor displays exactly what caused the last update of location and sensor
![Android](/assets/android.svg)<br />
This sensor will reflect the current level of illuminance the device detects. The sensor updates during the normal sensor update interval or with the other sensor updates and makes use of [Environment Sensors](https://developer.android.com/guide/topics/sensors/sensors_environment).

## Mobile Data Sensors
![Android](/assets/android.svg)<br />
Several different sensors around the state of mobile data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please include a link to the Android API that we use here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@frimtec frimtec requested a review from dshokouhi January 24, 2021 16:39
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged once the parent PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants