package/linux-firmware: add iwlwifi gl firmware #59
Conversation
antst
force-pushed
the
2024.02.x-haos-iwl-BE200
branch
3 times, most recently
from
150cd27 to
e5707ad
Compare
|
|
||
| LINUX_FIRMWARE_GL_UCODE_API_MAX = 83 |
There was a problem hiding this comment.
I'd like to keep this aligned with kernel naming to make updates a little easier. Also, keep it in one block:
| LINUX_FIRMWARE_GL_UCODE_API_MAX = 83 | |
| LINUX_FIRMWARE_IWL_BZ_UCODE_API_MAX = 83 |
There was a problem hiding this comment.
This one is incomplete, I'll commit it right way
| LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.iwlwifi_firmware | ||
| endif | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra newline:
| @@ -648,6 +650,14 @@ LINUX_FIRMWARE_FILES += iwlwifi-QuZ-*.ucode | |||
| LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.iwlwifi_firmware | |||
| endif | |||
|
|
|||
| ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL),y) | |||
| LINUX_FIRMWARE_FILES += \ | |||
| iwlwifi-gl-c0-fm-c0-$(LINUX_FIRMWARE_GL_UCODE_API_MAX).ucode\ | |||
There was a problem hiding this comment.
As above:
| iwlwifi-gl-c0-fm-c0-$(LINUX_FIRMWARE_GL_UCODE_API_MAX).ucode\ | |
| iwlwifi-gl-c0-fm-c0-$(LINUX_FIRMWARE_IWL_BZ_UCODE_API_MAX).ucode\ |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Just a comment to this:
It makes sense to me as well, however, in our fork we add the extra logic for deploying only a single microcode version. That's something that seemed to be irrelevant for upstream (and Intel cards are quite uncommon in traditional Buildroot targets anyway), so extra work is needed to merge changes on Buildroot update anyway. I have an idea in my head for some time already to create a HAOS-specific package for Intel firmwares which would make it possible separate these differences to a file that's fully controlled by us. |
|
Also, please squash all the changes into a single patch, so we can fast-forward merge this PR. |
This commit integrates support for the iwlwifi gl firmware files to support the wifi chipsets for the intel BE200 type of hardware. Thus, this change adds BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL.
antst
force-pushed
the
2024.02.x-haos-iwl-BE200
branch
from
8ef4427 to
1d7407c
Compare
|
Made requested changes. |
|
To be honest, I am also unhappy with "IWLWIFI_GL", but naming is not my thingy ))) |
This commit integrates support for the iwlwifi gl firmware files to support the wifi chipsets for the intel BE200 type of hardware. Thus, this change adds BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL.
To be honest, personally, I'd add this to already existing umbrella for Intel 6/6E adapters, instead of adding yet another build switch. Because, either we enable all Intel 6/6E adapters, or we enable them one by one.
But, just in case, made it with additional switch.
Alternatively I can rework into other version.