-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow --version to overwrite addon version #62
Conversation
Hi @einschmidt, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hi @einschmidt, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not enable --version
for addons furthermore, this will break the build if --version
is passed with --addon
since version
in the build_addon
function will be blank.
Thanks for the review @ludeeus. I reviewed the variables and changed the PR accordingly. |
Nice improvement, no more |
Goal
Allow to set the build version for add-ons via the --version or -v parameter.
Use-case
Using the GitHub actions, I want to be able to use different actions for different purposes, and different results. For example:
Change
desired example config