add username and password options to docker login #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
pvizeli
reviewed
Dec 5, 2019
builder.sh
Outdated
| @@ -107,6 +109,10 @@ Options: | |||
| Check if the version already exists before starting the build. | |||
| --docker-login | |||
| Login into docker hub on startup (need '-ti' docker opts) | |||
| --docker-user | |||
| Username to login into docker with | |||
| --docker-pass | |||
Changed it in all instances
|
I was over the code. Can you remove the old |
|
all done :) |
pvizeli
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables people to use the username and password for login to docker which sometimes causes errors with uploading.