Apply labels from add-on build.(yaml|json) when building add-on
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lildude
added a commit
to lildude/ha-addon-ghostfolio
that referenced
this pull request
Apr 7, 2024
lildude
added a commit
to lildude/ha-addon-ghostfolio
that referenced
this pull request
Apr 7, 2024
* Bump ghostfolio/ghostfolio from 2.65.0 to 2.71.0 Bumps ghostfolio/ghostfolio from 2.65.0 to 2.71.0. --- updated-dependencies: - dependency-name: ghostfolio/ghostfolio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update versions * Move labelling to dockerfile Bug: home-assistant/builder#203 * Bump version * Remove \ --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Colin Seymour <[email protected]>
agners
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered that the add-on builder doesn't apply the labels configured in the add-on's
build.(yaml|json)file.You can see this in action in the example add-on repo's packages as the "About this version" section hasn't been auto-populated:
... and the manifest shows the labels haven't been applied either:
This PR rectifies this by parsing the
build.(yaml|json)file for the labels inbuild_addon()in the same way as the other build functions do.