Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind mount /mnt for temporary build artifacts #193

Closed
wants to merge 1 commit into from
Closed

Conversation

agners
Copy link
Member

@agners agners commented Feb 15, 2024

The new GitHub Action hosted runners have less space on /. For some add-ons this can be problematic. Unfortunately it is not straight forward to use /mnt as Docker data root. Instead just mount /mnt inside the container so add-on Dockerfiles can use that location for temporary build files.

The new GitHub Action hosted runners have less space on /. For some
add-ons this can be problematic. Unfortunately it is not straight
forward to use /mnt as Docker data root. Instead just mount /mnt inside
the container so add-on Dockerfiles can use that location for temporary
build files.
@agners agners marked this pull request as draft February 15, 2024 13:07
@agners
Copy link
Member Author

agners commented Feb 15, 2024

I've realized this approach has a major drawback: To use that additional space we have to adjust the add-on Dockerfiles to use /mnt which essentially means we add GH action specific logic in Dockerfiles. This is problematic when running test builds of an add-on locally. I'd have to bind mount something to /mnt as well 😰

We could of course bind mount just a temporary volume there, and maybe even add that to the builder. But it is all a bit wonky. I think we need a better solution here 🤔

@agners
Copy link
Member Author

agners commented Apr 11, 2024

This is too hacky. Just make sure Dockerfiles don't use as much space 😅 . Closing.

@agners agners closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants