Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform if build information are not available #143

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

agners
Copy link
Member

@agners agners commented May 18, 2022

Currently, when build information are missing the following error is printed:

[15:41:46] ERROR: amd64 not supported for this build

This is rather misleading. Print an error when the build information are not available.

@mdegat01
Copy link
Contributor

mdegat01 commented May 18, 2022

So I see your point but one thing that's confusing me is that this file is actually optional. If build.json or build.yaml isn't provided then it simply uses latest as per here:
https://github.com/home-assistant/builder/blob/3e71d6f20f929b30ce69d6283eb7f2c468a4f8f5/builder.sh#L495-498

Therefore I wonder whether users would find this message more or less confusing? Users shouldn't see an error just for omitting build.json so when does this error actually occur and how do they fix it?

@agners
Copy link
Member Author

agners commented May 18, 2022

If build.json or build.yaml isn't provided then it simply uses latest as per here:

Afaik, that is only true for the addon build type, which this PR doesn't change.

@pvizeli
Copy link
Member

pvizeli commented Jun 13, 2022

I agree, it's possible to build an add-on without build information. The CI should filter out not needed arch builds, so the error is normally not show if it's using our latest CI

@agners
Copy link
Member Author

agners commented Sep 8, 2022

This fix is meant for manual builds.

I agree, it's possible to build an add-on without build information.

Correct, and add-on builds are not touched by this change.

So I guess it is fine then to merge this?

agners added 2 commits June 10, 2024 09:13
In most cases the user provides a build metadata file. Write an
informational log when the default is being used.
@agners agners force-pushed the warn-if-build-information-not-available branch from 3620ea6 to 526221e Compare June 10, 2024 07:17
@agners agners requested a review from mdegat01 June 10, 2024 07:19
@agners agners merged commit 2904dcb into master Jun 17, 2024
10 checks passed
@agners agners deleted the warn-if-build-information-not-available branch June 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants