Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 icons for edupage custom integration #6033

Closed
wants to merge 3 commits into from

Conversation

rine77
Copy link

@rine77 rine77 commented Oct 28, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@home-assistant home-assistant bot added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 28, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a domain which has a dash (-), which is not an allowed character for integration domains.

CleanShot 2024-11-04 at 11 39 11@2x

Please make sure the integration domain doesn't have invalid characters.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft November 4, 2024 10:39
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaasnicolaas klaasnicolaas changed the title added 2 icons for brand "homeassistant-edupage" - https://github.com/rine77/homeassistant-edupage Add 2 icons for edupage custom integration Nov 4, 2024
@rine77 rine77 marked this pull request as ready for review November 5, 2024 08:05
@home-assistant home-assistant bot requested a review from frenck November 5, 2024 08:05
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this PR as requested changes, as the issue hasn't been resolved.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft November 5, 2024 10:55
@rine77 rine77 closed this Nov 5, 2024
@home-assistant home-assistant bot removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants