Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the icon and logo files for once Custom Integration #6000

Closed
wants to merge 12 commits into from
Closed

Added the icon and logo files for once Custom Integration #6000

wants to merge 12 commits into from
+0 −0

Conversation

vincenzosuraci
Copy link
Contributor

@vincenzosuraci vincenzosuraci commented Oct 18, 2024 •
edited
Loading

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Vincenzo Suraci and others added 5 commits October 10, 2024 21:10
1. zyxel_lte5398_m904 dir added under custom_integration
ab8146b 
2. icon.png file added under custom_integration/zyxel_lte5398_m904
3. [email protected] file added under custom_integration/zyxel_lte5398_m904
4. logo.png file added under custom_integration/zyxel_lte5398_m904
5. [email protected] file added under custom_integration/zyxel_lte5398_m904
1. icon.png is 256x256
a2adb1a 
3. [email protected] is 512x512
1. icon.png is 256x256
74a7629 
3. [email protected] is 512x512
@vincenzosuraci
Merge branch 'home-assistant:master' into master
fef7676
Added 1nce HACS integration icons:
a99b380 
1. icon.png is 256x256
2. [email protected] is 512x512
3. logo.png is 598x256
4. [email protected] is 1195x512
@home-assistant home-assistant bot added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 18, 2024
frenck
frenck requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @vincenzosuraci 👋

The PR looks good, however, looking at the upstream manifest I saw a little issue that should be addressed.

CleanShot 2024-10-19 at 09 52 16@2x

aiothttp is a core requirement, and thus not be in the integration manifest, see also: https://developers.home-assistant.io/docs/creating_integration_manifest/#custom-integration-requirements

../Frenck

@home-assistant home-assistant bot marked this pull request as draft October 19, 2024 07:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@vincenzosuraci
Copy link
Contributor Author

Hi there @vincenzosuraci 👋

The PR looks good, however, looking at the upstream manifest I saw a little issue that should be addressed.

CleanShot 2024-10-19 at 09 52 16@2x

aiothttp is a core requirement, and thus not be in the integration manifest, see also: https://developers.home-assistant.io/docs/creating_integration_manifest/#custom-integration-requirements

../Frenck

Manu thanks for the feedback. I removed it from manifest,json

@vincenzosuraci
Copy link
Contributor Author

I added logo and icon also for another HACS custom integration (called ho.mobile) I'm working on: https://github.com/vincenzosuraci/hassio_ho.mobile_account

frenck
frenck requested changes Oct 25, 2024
View reviewed changes
custom_integrations/ho_mobile/icon.png Outdated Show resolved Hide resolved
I deleted 4 files of another PR: a PR should contain a single integra…
a223a10 
…tion. Please remove the last addition and make a separate PR for it.
@vincenzosuraci vincenzosuraci marked this pull request as ready for review October 28, 2024 07:07
frenck
frenck requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The domain in this PR:

CleanShot 2024-11-04 at 10 59 00@2x

Seems not the match the domain in the integration manifest:

CleanShot 2024-11-04 at 10 59 20@2x

This will cause the branding not to work. Could you please take a look?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft November 4, 2024 09:59
@vincenzosuraci vincenzosuraci changed the title Added the icon and logo files for 1nce Custom Integration Added the icon and logo files for once Custom Integration Nov 5, 2024
@vincenzosuraci
Copy link
Contributor Author

The domain in this PR:

CleanShot 2024-11-04 at 10 59 00@2x

Seems not the match the domain in the integration manifest:

CleanShot 2024-11-04 at 10 59 20@2x

This will cause the branding not to work. Could you please take a look?

../Frenck

I modified the dir name from "1nce" to "once"

@home-assistant home-assistant bot removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincenzosuraci @frenck