Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS response headers #4652

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add CORS response headers #4652

merged 1 commit into from
Sep 10, 2023

Conversation

steverep
Copy link
Member

@steverep steverep commented Sep 6, 2023

Proposed change

Add CORS response header to allow any origin. This is needed in order for the frontend service worker to cache the images without using an exorbitant amount of storage.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @steverep 👍

../Frenck

@frenck frenck merged commit 3589ed5 into master Sep 10, 2023
6 checks passed
@frenck frenck deleted the cors-headers branch September 10, 2023 19:38
@steverep
Copy link
Member Author

@frenck could you also force clear the Cloudflare cache so I can verify the frontend PR works properly?

@frenck
Copy link
Member

frenck commented Sep 10, 2023

@steverep The cache is cleared on each major release; I cannot clear the branding only.

@steverep
Copy link
Member Author

Okay, I'll just give it a week then

tsunglung pushed a commit to tsunglung/brands that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants