Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultrasync as custom component #2082

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

caronc
Copy link
Contributor

@caronc caronc commented Dec 10, 2020

Proposed change

I added a full Interlogix/ComNav UltraSync Alarm Panel as a Custom Component as a temporary way of getting uses to try it while the core integration is pending review.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

There is another PR similar to this where the ultrasync branding is being added to the core_integrations directory instead of this PR which places it in the custom_integrations one. I'm not sure if this is a problem, so I just wanted to bring this forward early in case it was. The intent here is to make the source readily available to those requesting it (also helps with testing too)

This ticket was created to full fill the only 2 check-boxes failed in my merge request into the HACS/default repository. It identifies that I needed branding icons defined (this is the PR for that). It also identified that i needed to create a PR against home-assistant/wheels-custom-integrations which can be found here

  • This PR fixes or closes issue: fixes # n/a
  • Link to code base pull request: n/a
  • Link to documentation pull request: n/a
  • Link to integration documentation on our website: caronc/ha-ultrasync

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @caronc 👍

This is fine. We can move the image to the core folder later 👍

@frenck frenck merged commit 8005a8a into home-assistant:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants