alarm-control-panel: Vacation Mode #500
-
ContextMultiple alarmpanel vendors have a vacation mode apart from existing modes like away, night and home:
We like to have this extra alarm status / mode added to the alarm-control-panel entity so users are able to do specific automation actions based on them being away for a longer time like close main water valves, specific light scenes or extra ventliation during specific hours ProposalAdding the extra vacation mode to the alarm-control-panel entity as well as the MQTT alarm class.
and contains the following modifications: Services
Along with a SUPPORT_ALARM_ARM_VACATION flag. States Device automations UI ConsequencesAll existing alarmpanels that have integrations within HA will not be impacted by adding this new alarm state. The integration component of the alarmpanel determines if this state is used or not. Currently it is impossible to have automation actions based on vacation without some extra manual interaction. With this new state the alarmpanel this will be possible. |
Beta Was this translation helpful? Give feedback.
Replies: 33 comments 14 replies
-
Ho does this work; when will this be discussed / follow'd up? |
Beta Was this translation helpful? Give feedback.
-
There's unfortunately no formal process or timeline for that. There needs to be some interest from organization members to look at this and comment. My initial thought is that 4/29 seems a bit low coverage for this feature to be added. Have you reviewed all existing integrations with alarm control panel platforms to gather the correct possible support level for this feature? |
Beta Was this translation helpful? Give feedback.
-
No i didn't. I don't know all integrations, i'm sure there will be more supporting vacation mode., i just searched google for some examples. @frenck suggested to open an architectural change request for this, but this change has no impact at all on all 29 alarm implementations other than making the new status available to panels that support it. |
Beta Was this translation helpful? Give feedback.
-
Before adding a new feature to an entity integration we want to assess the support for this feature among both existing integrations and for other devices of the same device type in the wild. It's easier to accept new features that we know are supported by a majority or at least large part of the integrations. So I'd advice to try and gather more data on this. |
Beta Was this translation helpful? Give feedback.
-
Apart from the list i provided i scanned the current alarm integrations and found the following to be supporting some sort of vacation mode:
So 11 out of 29 intergrations are supporting vacation mode (didn't count in MQTT as that would be implemented with my pull request). Apart from that; home and/or night modes aren't supported either on a lot of panels which do not support vacation mode, so if these modes are supported by HA so should vacation mode in my opinion. The use cases for vacation mode are much higher than for instance, home mode. |
Beta Was this translation helpful? Give feedback.
-
With 11/29 I'm ok with adding it. We should get some more opinions from other members before moving ahead. |
Beta Was this translation helpful? Give feedback.
-
For Verisure this is not a valid use-case. Verisure vacation/holiday mode is a setting for the alarm dispatch center to know who to contact between a certain period. It cannot be activated or read out from the alarm panel itself. Nevertheless, I don't see much harm in adding such a mode. |
Beta Was this translation helpful? Give feedback.
-
According to this python module it should have some information available: https://github.com/persandstrom/python-verisure, |
Beta Was this translation helpful? Give feedback.
-
Yes, but it isn't an alarm panel state. |
Beta Was this translation helpful? Give feedback.
-
Ok clear! |
Beta Was this translation helpful? Give feedback.
-
Hello, any updates on implementing vacation mode? |
Beta Was this translation helpful? Give feedback.
-
totalconnect API has no concept of vacation mode as described here. There would be no impact to totalconnect by implementing this. |
Beta Was this translation helpful? Give feedback.
-
Risco doesn't have a formal vacation mode (AFAIK), but it has 6 different arming modes, and the user can set one of them to something that would make sense when going on vacation. The integration is planned to allow custom mapping of HA arming modes to Risco arming modes (home-assistant/core#39218). |
Beta Was this translation helpful? Give feedback.
-
Seems fine to me. ElkM1 supports this and I'd be happy to add it. |
Beta Was this translation helpful? Give feedback.
-
at what period a decision will be made for this? My pull request is becoming stale again,. |
Beta Was this translation helpful? Give feedback.
-
Please also describe the frontend source changes needed for this feature. A frontend PR that implements this is required before we can merge the core PR. |
Beta Was this translation helpful? Give feedback.
-
There is no frontend change, just adding a alarm status. You can see all you need in the PR home-assistant/core#38284 |
Beta Was this translation helpful? Give feedback.
-
As I understand the core PR, it's adding a new service and a new state. This should normally be exposed by the frontend. It would help this architecture issue if we outline the proposed changes to the entity model here in the PR description. See eg this other issue: |
Beta Was this translation helpful? Give feedback.
-
I'm sorry i don't understand what i need to add where.. |
Beta Was this translation helpful? Give feedback.
-
First, in this PR description, outline the new alarm control panel state and service and corresponding entity method that you propose to add. Second, please describe how these new features will be exposed in the frontend. Normally, entity services are available to be run via the GUI. If we don't want this, please explain why so we can decide on this too. |
Beta Was this translation helpful? Give feedback.
-
@MartinHjelmare i tired to determine what you want me to add to this PR but i don't get it at all. The extra alarmstate is completely the same as, for instance, the nightmode implementation. There are no differences apart from the alarm state value. I would opt to use the nightmode implementations (core aswell as frontend) as reference for this new alarmstate. |
Beta Was this translation helpful? Give feedback.
-
For arm away mode there's a button in the lovelace card to activate this mode. Should we add this for the vacation mode? This is the sort of discussion I'm after. You haven't specifically described the APIs, and named them, that you want to add besides opening the core PR. I'd like you to do that here in the architecture issue top post so it's easier to understand and talk about this here. Please describe the API in terms of service and state, which are core building blocks in Home Assistant. |
Beta Was this translation helpful? Give feedback.
-
Ok i updated the description of this PR. I would opt for adding the button in lovelace to activate vacation mode. Also make visibility of this button customizable just as other states. |
Beta Was this translation helpful? Give feedback.
-
Sorry for interjecting, but I believe I understand what both sides here are after, so I'll try to tackle this: Services
Along with a States Device automations
UI
Hope this helps. |
Beta Was this translation helpful? Give feedback.
-
Many thanks @OnFreund i updated the comments! |
Beta Was this translation helpful? Give feedback.
-
Ok when will this proposal going forward? |
Beta Was this translation helpful? Give feedback.
-
As both Core and Frontend PR's are completed this architectual change can now be merged into master |
Beta Was this translation helpful? Give feedback.
-
Will this be part of the new upcoming Beta release? |
Beta Was this translation helpful? Give feedback.
-
PR's are all completed. When will this merge into new beta release?? |
Beta Was this translation helpful? Give feedback.
-
Backend & developer documentation has been merged, frontend is approved and awaiting merge. |
Beta Was this translation helpful? Give feedback.
Backend & developer documentation has been merged, frontend is approved and awaiting merge.