Log action for external bus improv/scan command #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a log statement with the app's decision to an Improv scan request to help with #4936, where nothing appears to happen.
Why: I expected the app requirements to be simple enough to verify and the library simply throws exceptions if things don't work, but right now it's unclear why nothing is happening. The line
D WebviewActivity: External bus {"type":"improv/scan","id":4}should be followed byI ImprovManager: Find Devices, if not something between the external bus and library seems to decide not to work and these lines should tell if that is the app.Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes