Add support for media players in device controls #4917
Merged
+154
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Dec 19, 2024
app/src/main/java/io/homeassistant/companion/android/controls/MediaPlayerControl.kt
Show resolved
Hide resolved
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Show resolved
Hide resolved
jpelgrom
reviewed
Dec 21, 2024
app/src/main/java/io/homeassistant/companion/android/controls/MediaPlayerControl.kt
Outdated
Show resolved
Hide resolved
|
Seems to work well, just not completely sure about the presentation yet (added two more comments). |
jpelgrom
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for media player entities in device controls.
Toggle control will play/pause, active state is only if
playingSlider control for volume if media player supports setting the volume
Behavior designed to match frontend as close as possible due to conversions for volume
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1149
Any other notes
Ref: https://community.home-assistant.io/t/wth-why-cant-media-player-entities-be-added-to-android-device-controls/813242
The actions accept any value, we don't particularly need to round things but good to keep things clean i think. Tested with a few of my media players.