Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct location batching call #4662

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

dshokouhi
Copy link
Member

Summary

This shouldve been done in #2999 however I just now noticed the mistake while reviewing the code to see why sometimes updates are just randomly delayed. I am not sure if this is the case but I wanted to use the correct API here. I am also ok with removing this line as well and not having any batching if that is what we would like to do. Apparently it was not working for a while 😬

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Ref of old API used: https://developers.google.com/android/reference/com/google/android/gms/location/LocationRequest#setMaxWaitTime(long)

@jpelgrom
Copy link
Member

I am also ok with removing this line as well and not having any batching if that is what we would like to do.

The system is already limiting background location updates so I think we can keep it in, makes it nicer for people on old devices while there should be no/minimal differences on modern devices.

@dshokouhi
Copy link
Member Author

ok will leave as is then :)

@jpelgrom jpelgrom merged commit 20ab91f into home-assistant:master Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants