add transparent background to media widget #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to configure the media widget to have a transparent background.
remove duplicated logic to check for dynamic colour support and when displayed the currently selected value.
ShaunPlummer
changed the title
ShaunPlummer
changed the title
ShaunPlummer
force-pushed
the
feat/transparent-media-widget
branch
from
6025a79 to
46c3099
Compare
dshokouhi
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the media widget to support transparent background. Particularly when nothing is playing the widget is playing it blocks a lot of the wallpaper.
Screenshots
Any other notes
Sometimes the text might not have a high enough contrast ratio with the background. I considered making the text colour customisable. This may require some additional (I see a number have already been defined) custom attributes for the views as
android.R.attr.textColorPrimarydoesn't appear to be available for the widget.