Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notification permission on Wear #4551

Merged

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Aug 3, 2024

Summary

To prepare for the API 33 targeting of Wear (#4500), add handling around the notification permission to the Wear app. This should only apply to watch notifications, not bridged notifications*, but it is nice to have if possible so:

  • Ask for notification permission immediately after completing onboarding (Android 13+ only)
  • Add a settings item to open the watch settings to grant permission (any Android version)

Screenshots

Permission prompt after logging in Settings item if notifications are disabled for the app Tapping the setting open the system notifications settings**
A screenshot of a dialog with the question 'Allow Home Assistant to send you notifications?', a bell icon, an obscured button near the bottom. Settings titled 'Notifications', one option labeled 'Enable notifications' System notification settings for Home Assistant, with a enable everything toggle at the top and individual notification channels below

Link to pull request in Documentation repository

n/a

Any other notes

* At least that's what Google says, but then you have Samsung making it impossible to change one without the other in their companion app 🤷
** Fun fact: while I can find this in settings app on the emulator, I actually can't find it on my Samsung watch

 - Ask for notification permission after completing onboarding
 - Add a settings item to open the watch notification settings to grant permission
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we dont have to make it clear this is for watch notifications only and not bridged :) Not sure why Samsung decided to hide the option, seems silly but maybe they did it for simplicity?

@dshokouhi dshokouhi merged commit 7a9efaa into home-assistant:master Sep 6, 2024
4 checks passed
@jpelgrom jpelgrom deleted the wear-notification-permission branch September 6, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants