Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper #4470

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

runningcode
Copy link
Contributor

Summary

This updates the Gradle wrapper. This is done by running the Gradle wrapper task twice.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@jpelgrom
Copy link
Member

The Gradle wrapper is updated and validated by the GitHub Action, but I'm also seeing other changes to scripts/build files? Could you explain those and/or point to a source?

@runningcode
Copy link
Contributor Author

Yes, you can create the exact same changeset on your machine by running ./gradlew wrapper --gradle-version 8.8.
The documentation here states Don’t forget to run the wrapper task again to download the Gradle distribution binaries (if needed) and update the gradlew and gradlew.bat files. This seems to have been missing whenever the last person updated these files. I'm not sure what Github action you have that updates the wrapper.
The Github Action validation ensures that a known Gradle wrapper matches the hash of the project's wrapper. In this case it is matching an older version.

@jpelgrom
Copy link
Member

Thanks for the additional info! Gradle updates are usually handled when required using Android Studio's update option.

@jpelgrom jpelgrom merged commit d788766 into home-assistant:master Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants