Add support for voice command action #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Apr 7, 2024
app/src/main/java/io/homeassistant/companion/android/assist/AssistActivity.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the voice command support so that Assist can be triggered via a headset. Notably the change includes adding the voice command intent for Assist, being able to wake up from it even when the screen is off, and stopping the current playing audio only when the activity is destroyed rather than paused, so that it doesn't interfere with screen turning off half way through the playback.
Screenshots
N/A
Link to pull request in Documentation repository
I don't think a doc update is needed?
Any other notes
This change was tested with/without the voice command and, other than the change in behavior where the playback will continue even with the screen turning off halfway, I've verified that no other UX regression is introduced.