Update Wear more details screen to prevent cut off #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cut-off # Conflicts: # wear/src/main/java/io/homeassistant/companion/android/home/views/DetailsPanelView.kt
JBassett
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the more details screen on a watch to prevent content from being cut off. The entity title and toggle were forced onto one line, so with longer entity names and/or larger text sizes it would get cut off.
New design prominently shows the entity icon, which can be tapped to toggle, and the entity title on another line (which can wrap / limit length). Design is very similar to the frontend tile card and default Wear round buttons with icons, so hopefully familiar to users. Colors are not dynamic - on is always yellow, matching the vehicle interface.
Screenshots
* and default text size
Link to pull request in Documentation repository
n/a
Any other notes