Fix listed beacons that are out of range after enable #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this fix the issue the previous PR to fix this encountered, where the live data is caching/sending old values? |
|
The Beacon Library finishes the current scan when we stop it and as we unbind the observer on stop we can use the check if any observer is bound. Otherwise we would empty the list and add the beacon which was found on the last scan to the empty list again. That's why the previous PR didn't work. |
dshokouhi
approved these changes
Mar 8, 2023
|
Yes, this is the only thing missing to make the Beacon Monitor work flawlessly ;-) |
JBassett
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR fixes a bug, where the beacon monitor lists iBeacons that are out of range after enabling.
#3010
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes