Only request multiple tasks for HA notification intents #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Nov 27, 2022
JBassett
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only request the use of multiple tasks for intents from notifications when dealing with the Home Assistant app. For other apps, allow the app to decide how to handle this to better match user expectations (for example other apps with notifications and the launcher) - in most cases the intent will add to an existing task.
Fixes #2976 as tabs are now always added to the existing set of tabs.
Screenshots
n/a
Link to pull request in Documentation repository
The app behavior for notification actions isn't documented and as I think this better matches expectations a docs PR seems unnecessary.
Any other notes