Fix location updates on core <2022.2 #3030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that #2969 breaks location updates for people on core <2022.2, which wasn't intended. This PR fixes that.
Always including
location_name
breaks compatibility with previous versions as it will reject updates:Received invalid webhook payload: string value is None for dictionary value @ data['location_name']. Got None
. Updates would look like this:Now, updates on core <2022.2 and when using the 'Exact' setting look like this (again):
And 'Zone name only' updates will only include the location name:
Only including non-null values works correctly on newer versions (it still clears the GPS data / switches to zone when sending just the
location_name
, and clears the forced zone when sending GPS data) and restores compatibility with older versions. Tested on:Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes
Reported on Discord