Don't check Wifi SSID when home wifi list is empty #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if the changes in #3015 will be considered 'location access' by this user's software? If so these changes will work but only until that PR is merged 😅 |
Well as long as we avoid any internal URL checks if home WiFi isn't set I guess it should be fine? |
Did a quick test and determining if the active network is WiFi also works without location access so yes it should be fine 👍 |
jpelgrom
approved these changes
Oct 31, 2022
JBassett
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If home wifi SSID is empty then do not bother checking the connected SSID or BSSID as we don't need to access the data.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
Ref: https://discord.com/channels/330944238910963714/562408603345092636/1036401886842064956