Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter in Manage Sensors to all/enabled/disabled #2950

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Oct 4, 2022

Summary

Update the filter menu in the 'Manage Sensors' screen to have options for all sensors, enabled sensors or disabled sensors, instead of the current filter which is equal to all sensors or enabled sensors (no option for disabled sensors).

Implements https://community.home-assistant.io/t/wth-cant-we-have-a-filter-in-android-app-to-only-disabled-sensors/468992

Screenshots

Light Dark
The 'Manage Sensors' screen with a menu shown in the top right with three options with radio buttons; 'All sensors' (selected), 'Enabled sensors' and 'Disabled sensors', light mode. The 'Manage Sensors' screen with a menu shown in the top right with three options with radio buttons; 'All sensors' (selected), 'Enabled sensors' and 'Disabled sensors', dark mode.

Link to pull request in Documentation repository

n/a

Any other notes

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JBassett JBassett merged commit 0ea8821 into home-assistant:master Oct 19, 2022
@jpelgrom jpelgrom deleted the settings-sensors-filter branch October 19, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants