Default to app icon if icon is not available for notification

[dshokouhi]

Summary

Default back to the app icon if the MDI icon does not exist in the library.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

[jpelgrom]

Nice improvement!

Based on a quick search, other places this could be useful:

• Media player widget shows a source icon if set using MDI or mdi:cast otherwise, but assumes if there is an icon value it is valid
• Wear OS entity chips show an icon, currently it actually handles null by not doing anything/keeping the placeholder (mdi:bookmark), use a domain icon or switch to showing nothing like the frontend?

[dshokouhi]

Media player widget shows a source icon if set using MDI or mdi:cast otherwise, but assumes if there is an icon value it is valid

So for this we should probably default back to mdi:cast in case its null

• Wear OS entity chips show an icon, currently it actually handles null by not doing anything/keeping the placeholder (mdi:bookmark), use a domain icon or switch to showing nothing like the frontend?

oh I didn't think it handled null based on

android/wear/src/main/java/io/homeassistant/companion/android/util/CommonFunctions.kt

Line 50 in 50d387a

IconicsDrawable(context, "cmd-$mdiIcon").icon

[jpelgrom]

oh I didn't think it handled null based on (...)

Not there, but in Compose it is handled:

android/wear/src/main/java/io/homeassistant/companion/android/home/views/EntityUi.kt

Line 60 in 203e686

asset = iconBitmap ?: CommunityMaterial.Icon.cmd_bookmark,