Option to bypass app lock on home network #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
reviewed
Aug 17, 2022
app/src/main/java/io/homeassistant/companion/android/settings/SettingsFragment.kt
Show resolved
Hide resolved
dshokouhi
approved these changes
Sep 2, 2022
JBassett
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the option to bypass the app (fingerprint) lock when on the home WiFi network.
Implements #840
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
isInternal()to check if the user is on their home WiFi network, but this does not work well if the internal URL is implicitly set to the same as the external URL. For the user it is unclear when that's the case.I feel this should be addressed in another issue.isHomeWifiSsid()and using that for checking the 'at home' state without interference of the internal URL.