Support downloading data URIs #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support for downloading data URIs - Redirect unsupported download requests to the browser (or other app that supports it)
JBassett
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the frontend is going to provide data URIs as downloads, the app should try to support them. Unfortunately the WebView won't give the suggested file name in the download callback, so a more generic one is used instead.
Fixes #2711
If the app receives a download request for something that is not supported (not http, https or data) it will now forward it to the system instead of crashing.
Screenshots
A notification will be posted that is very close to the system download manager in appearance and behavior.
Link to pull request in Documentation repository
n/a
Any other notes
Note for testing with frontend > Settings > Automations & Scenes > automation overflow menu > Debug automation > download icon: tapping on the notification probably won't do much as Android doesn't include an app that supports JSON files by default.