Fix editing service button widget shows/creates incorrect field values #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The text changed listener might be called while the button widget fields were being setup if a value exists. If other fields are bound at the same time this might overwrite their values and cause problems, so make sure to use the adapter position for the viewholder instead. - If setting a value fails set the text input to empty instead of showing the previous value
- Properly set the hint for the button widget fields to null if no hint is available to prevent an old hint from being visible - Properly set the autocomplete functionality to null if no autocomplete functionality is expected to prevent unwanted autocompletion
- Always load the full services list, even if a service was previously selected, and apply a filter on the list after setting it to prevent the dropdown from showing incorrect values
JBassett
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2604 and visual issues for the service fields
These fixes don't really relate to the changes included in the version I mentioned in the issue, but were mainly caused by race conditions/re-use of resources so I'm going to blame it on the app got faster 🙂
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes