Speed up device controls/Wear OS loading by doing network async #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Speed up loading the device controls menu and initial controls by launching all requests in an async block, which allows the server to respond out of order - For individual controls, only start listening for changes once we have provided initial controls
- Speed up a cold boot of the Wear OS app by launching all network requests in an async block, which allows the server to respond out of order
jpelgrom
changed the title
JBassett
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the device controls or Wear OS app, multiple messages have to be sent and received on the websocket connection in order to show the entity information. Right now the app waits on a response before sending the next message, which is inefficient because some requests take longer than others (depending on device/server/network/data/...). This PR changes these initial requests to be called
async- the app doesn't care in which order the responses arrive, as long as they all arrive before continuing.I've also included another small change in the device controls where it will now load the initial data first, and only start listening for updates after controls have been provided to the system.
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes