Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Compose preview for Play Store listing screens #2542

Merged
merged 4 commits into from
May 23, 2022

Conversation

jpelgrom
Copy link
Member

Summary

Adds Compose previews for screens that are in the Play Store listing, aka the onboarding screen and Wear OS 'scenes' screen.

Screenshots

image
image

Link to pull request in Documentation repository

n/a

Any other notes

jpelgrom added 2 commits May 23, 2022 21:36
 - Set theme correctly and show system UI
 - Add variant for dark mode
@dshokouhi
Copy link
Member

should we add the updated screenshots to the play folder?

https://github.com/home-assistant/android/blob/master/app/src/full/play/listings/en-US/graphics

Then once we merge this PR we can probably re-push to play store and see if they accept it? Really hope this is why its been rejected.

@JBassett
Copy link
Collaborator

should we add the updated screenshots to the play folder?

Yep, everything should be setup so changing those images will cause the play store listing to update as well.

Then once we merge this PR we can probably re-push to play store and see if they accept it? Really hope this is why its been rejected.

Will do once merged!

@jpelgrom
Copy link
Member Author

I've only updated the Wear OS screenshot for now, because the phone preview gives me a much lower resolution than the existing screenshots and it still mostly matches (Google aren't going to complain about font weight I hope?).

Perhaps a future improvement would be to redo all the screenshots with a demo configuration + document the device/emulator so that they can easily be re-done if necessary.

@JBassett JBassett merged commit a06f96f into home-assistant:master May 23, 2022
@jpelgrom jpelgrom deleted the play-listing-compose-preview branch May 23, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants