Add additional location setting to combine connected BT devices and e… #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntering a zone to enable high accuracy mode
|
Hey thanks for the PR! Let's make sure to document this new setting in the companion docs in this section: https://companion.home-assistant.io/docs/core/location#high-accuracy-mode |
|
Hey @dshokouhi ! |
|
@dshokouhi The PR for the documentation is open and can be found here: |
Thank's a lot ! :) |
JBassett
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntering a zone to enable high accuracy mode
Summary
Added a new setting to provide an "AND" functionality instead of only "OR" for combining connected BT devices and entering a specific zone to enable the high accuracy mode. This is related to the following issue:
#1673
Any other notes
Whenever there is no zone or device defined, but high accuracy is enabled as well as the combination, the combination setting will avoid to start the high accuracy mode as there is nothing to be combined. It made sense from my point of view (default is false anyways)