Don't block UI thread when opening tile + shortcuts settings #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't load the icon dialog's icon pack every time the fragment is resumed, it only needs to be loaded once - Don't load the icon dialog's icon pack on the main thread, instead load it on the IO thread to prevent blocking the fragment UI thread (as suggested in the loadDrawables function) - Clean up @RequiresApi(Build.VERSION_CODES.N_MR1) annotations
dshokouhi
approved these changes
Apr 12, 2022
JBassett
approved these changes
Apr 12, 2022
Notifications icons with The button widget does use the icon picker and loads icons on the main thread (at least it is only loaded once). It should probably be improved but I didn't think about the actual widget itself, and the configuration activity includes more blocking calls in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Did you ever notice that opening the tile and shortcuts settings takes a little longer than other settings fragments? Turns out it is because the app was loading all the icons for the icon picker on the main thread, every time the fragment resumed. This PR fixes that by moving it to a background thread and only doing it once.
(also cleaning up some annotations for the shortcuts fragment)
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes