Update Kotlin to 1.6 and Compose to 1.1 #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove @ExperimantalComposeUiApi, @ExperimentalWearMaterialApi annotations (because the functions aren't experimental, we are just using an experimental API) and replace with an opt-in declaration at the 'lowest level' usage - Websocket: ProducerScope is no longer experimental so the annotation can be completely removed - Wear: the animation APIs that are used for the time text are no longer experimental so the annotation can be completely removed
|
Not sure what I did wrong but after rebasing there were a lot of additional changes, so I've just done a regular merge which seems to work as well |
JBassett
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Kotlin to 1.6.10 and Compose to 1.1.1. Changes, aside from the version numbers:
@ExperimantalComposeUiApiand@ExperimentalWearMaterialApiannotations from the Home Assistant codebase, because the functions where they are used aren't experimental, we are just using an experimental API in those functions. After updating to 1.6 we now have to opt in to functions that use these annotations at a higher level for the build to succeed. The@OptIn(ExperimantalXApi::class)annotations are placed at the 'lowest level' usage (so where we directly use a function from Compose that has the experimental API annotation).ProducerScopeis no longer experimental so the annotation can be completely removed.Compose 1.1 also includes a breaking change for touch target sizing; I've checked all Compose based screens and nothing appears to be broken as a result of these changes.
Closes #2010
Screenshots
n/a
Link to pull request in Documentation repository
Not needed
Any other notes