Remove toast when updating state/camera/template widget fails #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
changed the title
- The error can also be because the selected entity no longer exists and/or the device failed to handle the response, so use a more generic error while refreshing icon
|
Decided to change the icon because it is shown on any failure, not just network related ones, and the previous cloud icon suggested otherwise. Screenshots have been updated. |
JBassett
requested changes
Feb 13, 2022
app/src/main/java/io/homeassistant/companion/android/widgets/entity/EntityWidget.kt
Outdated
Show resolved
Hide resolved
- Don't leak widget-specific calls in to a general variable, use a data class in order to be able to return two different data types
JBassett
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on discussion on Discord, this PR updates the camera, entity state and template widgets to remove the toast when updating the data fails, because these toasts could be very frequent1 and/or hard to attribute to a specific widget2, and show an icon on the specific widget that failed instead.
1: if the user tapped repeatedly to update toasts will 'queue', bad connections can cause problems for template widget updates because they update on any state change
2: entity state/template widgets cache data so they don't have an obvious 'not working' state
Screenshots
Showing failed updates, when the widget is able to update (again) the icon is not shown.
Link to pull request in Documentation repository
Not needed
Any other notes
CC @dshokouhi, thanks for the input