Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toggling covers and fans on Wear OS #2215

Merged
merged 4 commits into from
Jan 30, 2022

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Jan 30, 2022

Summary

This PR adds support to the Wear OS app to toggle other entities I could easily test: entities in the cover and fan domain. It also fixes the chip for locks being highlighted as on or off, but the toggle itself always being off.

Fixes #2211

Screenshots

Wear OS

Something changed in Android Studio 2021.1 and now my emulator screenshots are all fuzzy, sorry about that.

Wear OS home screen showing 'Covers' and 'Fans' domains options in the list

Open/closed for covers is 'converted' to on/off, matching device controls on phones.
'Covers' screen showing one cover named "Template cover" with status on

'Fans' screen showing two fans, with one turned on and another turned off

Phone settings

Light Dark
Companion app on phone showing the Wear OS favorite settings, with new entities cover/fan at the top of the list, light mode Companion app on phone showing the Wear OS favorite settings, with new entities cover/fan at the top of the list, dark mode

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#672

Any other notes

@dshokouhi
Copy link
Member

dont forget to update the phone app for favorites :)

 - Updates the Wear settings in the phone app to read from the app which domains are supported, and use this for filtering the list
 - Add strings for cover and fan domains
@jpelgrom
Copy link
Member Author

dont forget to update the phone app for favorites :)

Good point! I've added some additional logic to read the supported domains from the same list as the Wear OS app uses to prevent the phone app removing favorites if the apps are not on exactly the same version.

@JBassett JBassett merged commit 9a75391 into home-assistant:master Jan 30, 2022
@jpelgrom jpelgrom deleted the wear-toggle-cover-fan branch January 30, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fans as toggleable items (f.e. for whirlpools :)) for Wear OS
4 participants