Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog dialog to show when the app is updated #2195

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

dshokouhi
Copy link
Member

Summary

Fixes: #1162

Uses a library to help show a changelog prompt that is themed for day and night. The dialog will show up after the app is updated and can be accessed in settings as well.

As the github changelog won't be helpful to all users its probably in our best interest to decide on what to add in the changelog. There is some room for HTML like for emphasizing a breaking change. Probably a good time to discuss the format but I wanted to get this out so users don't have surprises like we saw with the new persistent notification.

During beta releases we should keep the version as Beta and only update it to the release version when we are ready to cut a release. This will allow us to keep the changelog for the release growing while we remain in beta. Again some of this we can decide to change later if we feel we need to based on user feedback and anything else we find during discussions.

Screenshots

image

image

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@JBassett JBassett merged commit 123494b into home-assistant:master Jan 25, 2022
@jrial
Copy link

jrial commented Jan 25, 2022

Does not fully resolve the problem. It's a step in the good direction, but I've already had to rescue systems that were no longer accessible over the network, and therefore in no position to be showing me any popups informing me of what I did wrong. Breaking changes, as the name implies, break things. You want to be forewarned of this, not (maybe) learn about it after the fact. Would be better if this popup would be triggered when you click the "update" button, and not just be shown at the end of the process, when things are already in a broken state.

@dshokouhi
Copy link
Member Author

Does not fully resolve the problem. It's a step in the good direction, but I've already had to rescue systems that were no longer accessible over the network, and therefore in no position to be showing me any popups informing me of what I did wrong. Breaking changes, as the name implies, break things. You want to be forewarned of this, not (maybe) learn about it after the fact. Would be better if this popup would be triggered when you click the "update" button, and not just be shown at the end of the process, when things are already in a broken state.

I think you might be confusing the Android app for an actual HA core update. There is nothing in the Google play store to cause such a prompt for an update. The breaking change in this case was to notify users of a new persistent notification. This PR directly solved the linked issue. Also in the future please don't comment on merged PRs instead create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a breaking changes prompt or notification upon updating, if needed
4 participants