Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing splash screen Wear OS #1896

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

HunterX86
Copy link
Contributor

Summary

  • Changed splash logo
  • Changed background color to @color/colorAccent

Screenshots

Added Logo with transparent background
splash_logo

Link to pull request in Documentation repository

N/A

Any other notes

Changed splash logo and accent color
@HunterX86 HunterX86 changed the title Fixing splash screen Fixing splash screen Wear OS Nov 10, 2021
@SkechyWolf
Copy link
Contributor

SkechyWolf commented Nov 10, 2021

Hey instead of adding a whole new image what if we just pulled in ic_launcher_foreground? and set the width and height to around 325px
Just an idea since we already have one with a transparent background it does lose some quality but it's not really noticeable.
Looks great by the way

@HunterX86
Copy link
Contributor Author

HunterX86 commented Nov 10, 2021

we can do that, as long as the background is the same blue color as the logo instead of black.

@dshokouhi
Copy link
Member

we can do that, as long as the background is the same blue color as the logo instead of black.

Any reason why this needs to be like that? The old screen was black and when I look at apps made by google that also have a splash screen the background is black behind the logo. The blue is also not the apps typical background color either. Can you share a screenshot of how it all looks together too please?

@HunterX86
Copy link
Contributor Author

This is what i meant.
I use the accentcolor that is used in the app.
splashscreen example

@dshokouhi
Copy link
Member

@HunterX86 any particular reason why the background color needs to match the logo instead of remaining black like the rest of the background color of the app is? Is there a material guideline I am missing here?

@HunterX86
Copy link
Contributor Author

HunterX86 commented Nov 10, 2021

There is not a paticulary material guideline for it, but don't you think it looks nice and clean.
If you don't agree with me, can you make it like this:
The background color is black and the logo color is the accentcolor.
splashscreen example2

@dshokouhi
Copy link
Member

There is not a paticulary material guideline for it, but don't you think it looks nice and clean. If you don't agree with me, can you make it like this: The background color is black and the logo color is the accentcolor.

So I am not a designer but when I look at other apps like Google Play Store they dont fill the screen entirely. I am ok with with this if everyone else is but you were quite particular about the background color which is why I enquired about it.

@HunterX86
Copy link
Contributor Author

So I am not a designer but when I look at other apps like Google Play Store they dont fill the screen entirely. I am ok with with this if everyone else is but you were quite particular about the background color which is why I enquired about it.

As a matter of fact i am a graphic designer 😃

Here are 2 examples of splashscreens that fills the whole screen with a background color
example 1
example 2

@dshokouhi
Copy link
Member

As a matter of fact i am a graphic designer 😃

Oh excellent we are very happy to have you here!!! Thank you for the provided examples as well :)

@JBassett JBassett merged commit 705a974 into home-assistant:master Nov 11, 2021
@home-assistant home-assistant locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants