-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wear OS Settings section #1796
Add Wear OS Settings section #1796
Conversation
This is great! One question: what happens for users that are not using the beta app, while the wear os app only has a beta version? |
So if a user signs up for the beta then they get both phone and wear app in the play store. In this case though the wear app needs to send out the new capability that is defined for the recognition to work. Most of these features will require updates to both phone and wear so I would say we need the apps to stay in sync when we need to do things like this. |
And what if the user hasn't yet signed up for the beta program? Will the link to the play store still work? |
Hmm it probably won't work and in the app we don't have a reliable way that I am aware of to detect beta users as those users can be on the production version depending on when they got the update and if a new beta was cut and pushed to the play store. Maybe we should change the messaging until we are ready for a production release? |
Yeah, I don't see a straightforward way to detect it either. But maybe you can just add it in the description, to notify the user that a beta version is required? |
So in our play store listing we were required to mention it so we have this one liner: https://play.google.com/store/apps/details?id=io.homeassistant.companion.android What I can do also is to just add a note with a link to the beta so the user can sign up there too in case the app doesn't install or the link isn't working. |
Awesome! Seems very clear to me :) |
7e7b7f6
to
2c0bbec
Compare
89ece3d
to
0a22b8a
Compare
Was just wondering what about the galaxy watch as with the galaxy watch 4 it has you install the Samsung wearable app |
Had no idea that watch needed a different app, according to Google its the only one that uses a different app. Will need to update the condition to look for that https://support.google.com/wearos/answer/6056630?hl=en&co=GENIE.Platform%3DAndroid Also in the future please don't comment on merged PR's as this might get missed an issue would be more appropriate :) |
Summary
Adds a new settings section that only shows up if a user has the Wear OS app installed as its then safe to assume we can check for active wear devices and check if the wear app is installed. This largely follows Googles example app along with our own logic. I left it as is for now so we can come back and update this section as we see fit. For now I thought it would be nice to let users know that they can install the app from here and that the initial communication is ready to go for adding future features. If the user does not have our wear app installed they can click a button to launch the play store so they can install the app.
https://github.com/android/wear-os-samples/tree/main/WearVerifyRemoteApp
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pending
Any other notes