Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for deprecations #457

Closed
ggravlingen opened this issue Mar 13, 2022 · 2 comments
Closed

Suggestions for deprecations #457

ggravlingen opened this issue Mar 13, 2022 · 2 comments
Assignees

Comments

@ggravlingen
Copy link
Member

ggravlingen commented Mar 13, 2022

Listing the things we've been discussing to deprecate, and adding a few suggestions on my own:

  • Command._add__: not in use?
  • Command.combine_data not in use?
  • smart_task.StartAction.devices: can't see this being used anywhere, nor that it adds any functionality?
  • libcoap_api: do we really need to keep maintaining this?
@ggravlingen ggravlingen self-assigned this Mar 13, 2022
@ggravlingen
Copy link
Member Author

Ping @MartinHjelmare for discussion.

@MartinHjelmare
Copy link
Contributor

MartinHjelmare commented Mar 13, 2022

What does the ROOT_START_ACTION item mean?

I think it could be ok to deprecate the libcoap api. Although currently it doesn't add very much maintenance burden either I think. So I would recommend keeping it.

MartinHjelmare pushed a commit that referenced this issue Oct 31, 2022
Bumps
[flake8-comprehensions](https://github.com/adamchainz/flake8-comprehensions)
from 3.10.0 to 3.10.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/adamchainz/flake8-comprehensions/blob/main/HISTORY.rst">flake8-comprehensions's
changelog</a>.</em></p>
<blockquote>
<h2>3.10.1 (2022-10-29)</h2>
<ul>
<li>
<p>Fix false positive in rules C402 and C404 for <code>dict()</code>
calls with keyword arguments.</p>
<p>Thanks to Anders Kaseorg for the report in <code>Issue
[#457](adamchainz/flake8-comprehensions#457)
&lt;https://github.com/adamchainz/flake8-comprehensions/issues/457&gt;</code>__.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/1eb8823d91f7d77d6cd54c212cb3b2cc58122099"><code>1eb8823</code></a>
Version 3.10.1</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/e655c2648513dc0e57e17cac6b70468b42338c89"><code>e655c26</code></a>
Fix C402/C404 false positive for dict() with kwargs (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/458">#458</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/7d8f47f93acbf89d79671c2745ef102c1c84de21"><code>7d8f47f</code></a>
Test with Python 3.11.0 (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/456">#456</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/26681c62d031f1c8828268e350fcaac6bc958dcf"><code>26681c6</code></a>
Upgrade requirements (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/455">#455</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/4fb5a39ccd3746caaa33122e2d1aa72b72d7aff6"><code>4fb5a39</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/453">#453</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/778eaad4b7518973c53f56604eb11d6c927628ef"><code>778eaad</code></a>
Upgrade GitHub Actions workflows to Ubuntu 22.04 (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/452">#452</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/baa8acd66b4582e473d21143ddd3f76887ab9c39"><code>baa8acd</code></a>
Add 'Typing :: Typed' PyPI classifier</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/76a79c07559f107cf62fd8115fcc85eea0e94181"><code>76a79c0</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/451">#451</a>)</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/763cf2a10c3981ad2d85f14fc2c02e33edc5a672"><code>763cf2a</code></a>
Upgrade to Mypy 0.981</li>
<li><a
href="https://github.com/adamchainz/flake8-comprehensions/commit/eb96bb6a11b9db8947d86a8ccdd4a95bf9ec527d"><code>eb96bb6</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://github-redirect.dependabot.com/adamchainz/flake8-comprehensions/issues/450">#450</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/adamchainz/flake8-comprehensions/compare/3.10.0...3.10.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=flake8-comprehensions&package-manager=pip&previous-version=3.10.0&new-version=3.10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants